Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ノート通知で絵文字が使われている名前が絵文字で表示されない #11878

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Sep 23, 2023

What

Misskey2023.9.0-RC.2でノート通知に絵文字が反映されない
Fix: #11877

Why

ノート通知で名前に絵文字が表示されない
-> 表示されるように
image

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (19bc9c2) 78.95% compared to head (55485b8) 78.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11878      +/-   ##
===========================================
- Coverage    78.95%   78.86%   -0.09%     
===========================================
  Files          928      929       +1     
  Lines        98408    98513     +105     
  Branches      7861     7835      -26     
===========================================
  Hits         77694    77694              
- Misses       20714    20819     +105     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit ed53b5f into misskey-dev:develop Sep 23, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 23, 2023

👍

@tai-cha tai-cha deleted the fix-note-notify-emoji-username branch September 24, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ノート通知で絵文字が使われている名前が絵文字で表示されない
2 participants